feat: Add name and instance_type as output #457
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longkb
changed the title
longkb
changed the title
|
Hi @bryantbiggs, could you help me to review this PR :) |
|
This is just re-exporting the inputs - why is that useful at all? |
|
closing this out for now - if you need to refer to these values, use a local value and pass that to the module and any other resources as needed. because these are pass through values, terraform won't wait on them like computed attributes |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Instance name and Instance type to module outputs.
Motivation and Context
Since these output for Instance is missing, we can't directly refer to the module to fetch these Information and make it as input of another module. To fetch it requires additional actions.
Breaking Changes
None, module logic untouched.